---
name: engineering-manager-plan-review
description: "Locks the technical plan before coding starts: architecture, data flow, edge cases, and a test plan an engineer can build from without guessing. Use when an engineer or tech lead has a feature plan and needs the architecture, data flow, edge cases, and tests settled before implementation. Do not use for reviewing finished code or choosing a technology stack from scratch. Related topics: coding, product."
---

# Engineering Manager Plan Review

Locks the technical plan before coding starts: architecture, data flow, edge cases, and a test plan an engineer can build from without guessing.

## When to use

Use this skill when an engineer or tech lead has a feature plan and needs the architecture, data flow, edge cases, and tests settled before implementation. Do not use it for reviewing finished code or choosing a technology stack from scratch.

## Workflow

1. Ask the user for each input listed below in a single message, skipping any they have already given. Where options are listed, offer them, but accept other answers too.
2. Name each component with what it owns and what it must not touch, and flag unclear ownership.
3. Trace one request through the system, marking every shape change and trust boundary.
4. List at least eight edge cases, including retries, partial failure, and concurrent writes.
5. Map every edge case to a named test at the right level.
6. Produce a numbered build order of small steps plus the open questions blocking step one.

## Inputs

- **Feature and goal** (longer free text)
- **Proposed approach** (longer free text)
- **Existing system** (longer free text)
- **Expected load and data size** (free text, e.g. "Requests or rows per day")
- **Hard constraints** (longer free text)
- **Team size** (number from 1 to 20)

## Output

Sections for architecture, data flow, edge cases, failure handling, and test plan, then a numbered build order, blocking questions, and a go or no-go call.

## Prompt template

Fill the inputs into this template and follow it as the full instruction.

### Engineering Manager Plan Review

Review my implementation plan before anyone starts coding.

- Feature and goal: {{Feature and goal}}
- Proposed approach: {{Proposed approach}}
- Existing system: {{Existing system}}
- Expected load and data size: {{Expected load and data size}}
- Hard constraints: {{Hard constraints}}
- Team size: {{Team size}}

Walk the plan in this order. Architecture: name each component, what it owns, and what it must never touch. Data flow: trace one request from entry to storage and back, marking every place data changes shape or crosses a trust boundary. Edge cases: list at least eight, including empty input, duplicates, partial failure, retries, concurrent writes, and migration of existing data. Failure handling: for each external call say what happens on timeout. Test plan: map each edge case to a unit, integration, or end to end test. Finish with a numbered build order of small shippable steps, the open questions that block step one, and a go or no-go call for starting today.

## Pitfalls

- Reviewing the happy path only, so the plan breaks on the first retry or duplicate.
- Listing tests without tying them to a specific risk.
- Skipping migration of existing data, the part that usually delays release.